fix: merge xRoute/xPolicy statuses across controllers in provider runner #7558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (18.61%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7558 +/- ##
==========================================
- Coverage 72.43% 72.25% -0.18%
==========================================
Files 232 232
Lines 34307 34392 +85
==========================================
+ Hits 24849 24851 +2
- Misses 7682 7761 +79
- Partials 1776 1780 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
y-rabie
force-pushed
the
merge-status-across-controllers
branch
from
6ffa015 to
9769a3c
Compare
y-rabie
changed the title
Signed-off-by: y-rabie <[email protected]>
y-rabie
force-pushed
the
merge-status-across-controllers
branch
2 times, most recently
from
9abf08f to
02d6094
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
/retest |
Signed-off-by: y-rabie <[email protected]>
Signed-off-by: y-rabie <[email protected]>
y-rabie
force-pushed
the
merge-status-across-controllers
branch
from
02d6094 to
ae16e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second and last PR split from #7307 (includes the changes of #7557, will rebase when it's merged)
E2e tests should be successful here.